Remove stupid, obviously flaky test

The locale is only used during error handling, and makes it harder for
users to report errors

examples/fetch.py

@@ -2,7 +2,7 @@ import fbchat
 
 session = fbchat.Session.login("<email>", "<password>")
 
-client = fbchat.Client(session)
+client = fbchat.Client(session=session)
 
 # Fetches a list of all users you're currently chatting with, as `User` objects
 users = client.fetch_all_users()

examples/interract.py

@@ -60,7 +60,7 @@ thread.set_color("#0084ff")
 # Will change the thread emoji to `👍`
 thread.set_emoji("👍")
 
-message = fbchat.Message(session=session, id="<message id>")
+message = fbchat.Message(thread=thread, id="<message id>")
 
 # Will react to a message with a 😍 emoji
 message.react("😍")

fbchat/__init__.py

@@ -118,7 +118,7 @@ from ._listen import Listener
 
 from ._client import Client
 
-__version__ = "2.0.0a3"
+__version__ = "2.0.0a5"
 
 __all__ = ("Session", "Listener", "Client")
 

fbchat/_client.py

@@ -419,7 +419,7 @@ class Client:
         Warning:
             This is not finished, and the API may change at any point!
         """
-        at = datetime.datetime.utcnow()
+        at = _util.now()
         form = {
             "folders[0]": "inbox",
             "client": "mercury",
@@ -558,7 +558,7 @@ class Client:
             "shouldSendReadReceipt": "true",
         }
 
-        for threads in threads:
+        for thread in threads:
             data["ids[{}]".format(thread.id)] = "true" if read else "false"
 
         j = self.session._payload_post("/ajax/mercury/change_read_status.php", data)

fbchat/_exception.py

@@ -124,11 +124,11 @@ def handle_graphql_errors(j):
         errors = j["errors"]
     if errors:
         error = errors[0]  # TODO: Handle multiple errors
-        # TODO: Use `severity` and `description`
+        # TODO: Use `severity`
         raise GraphQLError(
             # TODO: What data is always available?
             message=error.get("summary", "Unknown error"),
-            description=error.get("message", ""),
+            description=error.get("message") or error.get("description") or "",
             code=error.get("code"),
             debug_info=error.get("debug_info"),
         )

fbchat/_session.py

@@ -15,7 +15,9 @@ from . import _graphql, _util, _exception
 from typing import Optional, Mapping, Callable, Any
 
 
-SERVER_JS_DEFINE_REGEX = re.compile(r'require\("ServerJSDefine"\)\)?\.handleDefines\(')
+SERVER_JS_DEFINE_REGEX = re.compile(
+    r'(?:"ServerJS".{,100}\.handle\({.*"define":)|(?:require\("ServerJSDefine"\)\)?\.handleDefines\()'
+)
 SERVER_JS_DEFINE_JSON_DECODER = json.JSONDecoder()
 
 
@@ -24,6 +26,8 @@ def parse_server_js_define(html: str) -> Mapping[str, Any]:
     # Find points where we should start parsing
     define_splits = SERVER_JS_DEFINE_REGEX.split(html)
 
+    # TODO: Extract jsmods "require" and "define" from `bigPipe.onPageletArrive`?
+
     # Skip leading entry
     _, *define_splits = define_splits
 
@@ -89,6 +93,12 @@ def session_factory() -> requests.Session:
     from . import __version__
 
     session = requests.session()
+    # Override Facebook's locale detection during the login process.
+    # The locale is only used when giving errors back to the user, so giving the errors
+    # back in English makes it easier for users to report.
+    session.cookies = session.cookies = requests.cookies.merge_cookies(
+        session.cookies, {"locale": "en_US"}
+    )
     session.headers["Referer"] = "https://www.messenger.com/"
     # We won't try to set a fake user agent to mask our presence!
     # Facebook allows us access anyhow, and it makes our motives clearer:
@@ -97,6 +107,10 @@ def session_factory() -> requests.Session:
     return session
 
 
+def login_cookies(at: datetime.datetime):
+    return {"act": "{}/0".format(_util.datetime_to_millis(at))}
+
+
 def client_id_factory() -> str:
     return hex(int(random.random() * 2 ** 31))[2:]
 
@@ -106,7 +120,7 @@ def find_form_request(html: str):
 
     form = soup.form
     if not form:
-        raise _exception.ParseError("Could not find form to submit", data=soup)
+        raise _exception.ParseError("Could not find form to submit", data=html)
 
     url = form.get("action")
     if not url:
@@ -130,38 +144,58 @@ def two_factor_helper(session: requests.Session, r, on_2fa_callback):
 
     # You don't have to type a code if your device is already saved
     # Repeats if you get the code wrong
-    while "approvals_code" not in data:
+    while "approvals_code" in data:
         data["approvals_code"] = on_2fa_callback()
         log.info("Submitting 2FA code")
-        r = session.post(url, data=data, allow_redirects=False)
+        r = session.post(
+            url, data=data, allow_redirects=False, cookies=login_cookies(_util.now())
+        )
+        log.debug("2FA location: %s", r.headers.get("Location"))
         url, data = find_form_request(r.content.decode("utf-8"))
 
     # TODO: Can be missing if checkup flow was done on another device in the meantime?
     if "name_action_selected" in data:
         data["name_action_selected"] = "save_device"
         log.info("Saving browser")
-        r = session.post(url, data=data, allow_redirects=False)
+        r = session.post(
+            url, data=data, allow_redirects=False, cookies=login_cookies(_util.now())
+        )
+        log.debug("2FA location: %s", r.headers.get("Location"))
+        url = r.headers.get("Location")
+        if url and url.startswith("https://www.messenger.com/login/auth_token/"):
+            return url
         url, data = find_form_request(r.content.decode("utf-8"))
 
     log.info("Starting Facebook checkup flow")
-    r = session.post(url, data=data, allow_redirects=False)
+    r = session.post(
+        url, data=data, allow_redirects=False, cookies=login_cookies(_util.now())
+    )
+    log.debug("2FA location: %s", r.headers.get("Location"))
 
     url, data = find_form_request(r.content.decode("utf-8"))
+    if "verification_method" in data:
+        raise _exception.NotLoggedIn(
+            "Your account is locked, and you need to log in using a browser, and verify it there!"
+        )
     if "submit[This was me]" not in data or "submit[This wasn't me]" not in data:
         raise _exception.ParseError("Could not fill out form properly (2)", data=data)
     data["submit[This was me]"] = "[any value]"
     del data["submit[This wasn't me]"]
     log.info("Verifying login attempt")
-    r = session.post(url, data=data, allow_redirects=False)
+    r = session.post(
+        url, data=data, allow_redirects=False, cookies=login_cookies(_util.now())
+    )
+    log.debug("2FA location: %s", r.headers.get("Location"))
 
     url, data = find_form_request(r.content.decode("utf-8"))
     if "name_action_selected" not in data:
         raise _exception.ParseError("Could not fill out form properly (3)", data=data)
     data["name_action_selected"] = "save_device"
     log.info("Saving device again")
-    r = session.post(url, data=data, allow_redirects=False)
-
-    print(r.status_code, r.url, r.headers)
+    r = session.post(
+        url, data=data, allow_redirects=False, cookies=login_cookies(_util.now())
+    )
+    log.debug("2FA location: %s", r.headers.get("Location"))
     return r.headers.get("Location")
 
 
@@ -171,7 +205,6 @@ def get_error_data(html: str) -> Optional[str]:
         html, "html.parser", parse_only=bs4.SoupStrainer("form", id="login_form")
     )
     # Attempt to extract and format the error string
-    # The error message is in the user's own language!
     return " ".join(list(soup.stripped_strings)[1:3]) or None
 
 
@@ -232,7 +265,9 @@ class Session:
             on_2fa_callback: Function that will be called, in case a two factor
                 authentication code is needed. This should return the requested code.
 
-                Only tested with SMS codes, might not work with authentication apps.
+                Tested using SMS and authentication applications. If you have both
+                enabled, you might not receive an SMS code, and you'll have to use the
+                authentication application.
 
                 Note: Facebook limits the amount of codes they will give you, so if you
                 don't receive a code, be patient, and try again later!
@@ -275,6 +310,7 @@ class Session:
                 "https://www.messenger.com/login/password/",
                 data=data,
                 allow_redirects=False,
+                cookies=login_cookies(_util.now()),
             )
         except requests.RequestException as e:
             _exception.handle_requests_error(e)
@@ -292,17 +328,30 @@ class Session:
                 raise _exception.NotLoggedIn(
                     "2FA code required! Please supply `on_2fa_callback` to .login"
                 )
-            # Get a facebook.com url that handles the 2FA flow
+            # Get a facebook.com/checkpoint/start url that handles the 2FA flow
             # This probably works differently for Messenger-only accounts
             url = _util.get_url_parameter(url, "next")
-            # Explicitly allow redirects
-            r = session.get(url, allow_redirects=True)
+            if not url.startswith("https://www.facebook.com/checkpoint/start/"):
+                raise _exception.ParseError("Failed 2fa flow (1)", data=url)
+
+            r = session.get(
+                url, allow_redirects=False, cookies=login_cookies(_util.now())
+            )
+            url = r.headers.get("Location")
+            if not url or not url.startswith("https://www.facebook.com/checkpoint/"):
+                raise _exception.ParseError("Failed 2fa flow (2)", data=url)
+
+            r = session.get(
+                url, allow_redirects=False, cookies=login_cookies(_util.now())
+            )
             url = two_factor_helper(session, r, on_2fa_callback)
 
             if not url.startswith("https://www.messenger.com/login/auth_token/"):
-                raise _exception.ParseError("Failed 2fa flow", data=url)
+                raise _exception.ParseError("Failed 2fa flow (3)", data=url)
 
-            r = session.get(url, allow_redirects=False)
+            r = session.get(
+                url, allow_redirects=False, cookies=login_cookies(_util.now())
+            )
             url = r.headers.get("Location")
 
         if url != "https://www.messenger.com/":
@@ -458,7 +507,7 @@ class Session:
         return self._post("/api/graphqlbatch/", data, as_graphql=True)
 
     def _do_send_request(self, data):
-        now = datetime.datetime.utcnow()
+        now = _util.now()
         offline_threading_id = _util.generate_offline_threading_id()
         data["client"] = "mercury"
         data["author"] = "fbid:{}".format(self._user_id)

fbchat/_threads/_abc.py

@@ -116,8 +116,14 @@ class ThreadABC(metaclass=abc.ABCMeta):
             reply_to_id: Optional message to reply to
 
         Example:
+            Send a message with a mention to a thread.
+
             >>> mention = fbchat.Mention(thread_id="1234", offset=5, length=2)
-            >>> thread.send_text("A message", mentions=[mention])
+            >>> message_id = thread.send_text("A message", mentions=[mention])
+
+            Reply to the message.
+
+            >>> thread.send_text("A reply", reply_to_id=message_id)
 
         Returns:
             The sent message
@@ -211,7 +217,7 @@ class ThreadABC(metaclass=abc.ABCMeta):
         Example:
             Send a pinned location in Beijing, China.
 
-            >>> thread.send_location(39.9390731, 116.117273)
+            >>> thread.send_pinned_location(39.9390731, 116.117273)
         """
         self._send_location(False, latitude=latitude, longitude=longitude)
 

fbchat/_util.py

@@ -56,23 +56,26 @@ def parse_json(text: str) -> Any:
 
 
 def generate_offline_threading_id():
-    ret = datetime_to_millis(datetime.datetime.utcnow())
+    ret = datetime_to_millis(now())
     value = int(random.random() * 4294967295)
     string = ("0000000000000000000000" + format(value, "b"))[-22:]
     msgs = format(ret, "b") + string
     return str(int(msgs, 2))
 
 
+def remove_version_from_module(module):
+    return module.split("@", 1)[0]
+
+
 def get_jsmods_require(require) -> Mapping[str, Sequence[Any]]:
     rtn = {}
     for item in require:
         if len(item) == 1:
             (module,) = item
-            rtn[module] = []
+            rtn[remove_version_from_module(module)] = []
             continue
-        method = "{}.{}".format(item[0], item[1])
-        requirements = item[2]
-        arguments = item[3]
+        module, method, requirements, arguments = item
+        method = "{}.{}".format(remove_version_from_module(module), method)
         rtn[method] = arguments
     return rtn
 
@@ -155,3 +158,11 @@ def timedelta_to_seconds(td: datetime.timedelta) -> int:
     The returned seconds will be rounded to the nearest whole number.
     """
     return round(td.total_seconds())
+
+
+def now() -> datetime.datetime:
+    """The current time.
+
+    Similar to datetime.datetime.now(), but returns a non-naive datetime.
+    """
+    return datetime.datetime.now(tz=datetime.timezone.utc)

tests/online/conftest.py

@@ -17,12 +17,51 @@ def session(pytestconfig):
 
     pytestconfig.cache.set("session_cookies", session.get_cookies())
 
+    # TODO: Allow the main session object to be closed - and perhaps used in `with`?
+    session._session.close()
+
 
 @pytest.fixture
 def client(session):
     return fbchat.Client(session=session)
 
 
+@pytest.fixture(scope="session")
+def user(pytestconfig, session):
+    user_id = pytestconfig.cache.get("user_id", None)
+    if not user_id:
+        user_id = input("A user you're chatting with's id: ")
+        pytestconfig.cache.set("user_id", user_id)
+    return fbchat.User(session=session, id=user_id)
+
+
+@pytest.fixture(scope="session")
+def group(pytestconfig, session):
+    group_id = pytestconfig.cache.get("group_id", None)
+    if not group_id:
+        group_id = input("A group you're chatting with's id: ")
+        pytestconfig.cache.set("group_id", group_id)
+    return fbchat.Group(session=session, id=group_id)
+
+
+@pytest.fixture(
+    scope="session",
+    params=[
+        "user",
+        "group",
+        "self",
+        pytest.param("invalid", marks=[pytest.mark.xfail()]),
+    ],
+)
+def any_thread(request, session, user, group):
+    return {
+        "user": user,
+        "group": group,
+        "self": session.user,
+        "invalid": fbchat.Thread(session=session, id="0"),
+    }[request.param]
+
+
 @pytest.fixture
 def listener(session):
     return fbchat.Listener(session=session, chat_on=False, foreground=False)

tests/online/test_client.py

@@ -46,11 +46,6 @@ def test_undocumented(client):
     client.fetch_unseen()
 
 
-@pytest.mark.skip(reason="need a way to get an image id")
-def test_fetch_image_url(client):
-    client.fetch_image_url("TODO")
-
-
 @pytest.fixture
 def open_resource(pytestconfig):
     def get_resource_inner(filename):
@@ -60,6 +55,14 @@ def open_resource(pytestconfig):
     return get_resource_inner
 
 
+def test_upload_and_fetch_image_url(client, open_resource):
+    with open_resource("image.png") as f:
+        ((id, mimetype),) = client.upload([("image.png", f, "image/png")])
+    assert mimetype == "image/png"
+
+    assert client.fetch_image_url(id).startswith("http")
+
+
 def test_upload_image(client, open_resource):
     with open_resource("image.png") as f:
         _ = client.upload([("image.png", f, "image/png")])
@@ -90,5 +93,24 @@ def test_upload_many(client, open_resource):
         )
 
 
-# def test_mark_as_read(client):
-#     client.mark_as_read([thread1, thread2])
+def test_mark_as_read(client, user, group):
+    client.mark_as_read([user, group], fbchat._util.now())
+
+
+def test_mark_as_unread(client, user, group):
+    client.mark_as_unread([user, group], fbchat._util.now())
+
+
+def test_move_threads(client, user, group):
+    client.move_threads(fbchat.ThreadLocation.PENDING, [user, group])
+    client.move_threads(fbchat.ThreadLocation.INBOX, [user, group])
+
+
+@pytest.mark.skip(reason="need to have threads to delete")
+def test_delete_threads():
+    pass
+
+
+@pytest.mark.skip(reason="need to have messages to delete")
+def test_delete_messages():
+    pass

tests/online/test_send.py

@@ -0,0 +1,42 @@
+import pytest
+import fbchat
+
+pytestmark = pytest.mark.online
+
+
+# TODO: Verify return values
+
+
+def test_wave(any_thread):
+    assert any_thread.wave(True)
+    assert any_thread.wave(False)
+
+
+def test_send_text(any_thread):
+    assert any_thread.send_text("Test")
+
+
+def test_send_text_with_mention(any_thread):
+    mention = fbchat.Mention(thread_id=any_thread.id, offset=5, length=8)
+    assert any_thread.send_text("Test @mention", mentions=[mention])
+
+
+def test_send_emoji(any_thread):
+    assert any_thread.send_emoji("😀", size=fbchat.EmojiSize.LARGE)
+
+
+def test_send_sticker(any_thread):
+    assert any_thread.send_sticker("1889713947839631")
+
+
+def test_send_location(any_thread):
+    any_thread.send_location(51.5287718, -0.2416815)
+
+
+def test_send_pinned_location(any_thread):
+    any_thread.send_pinned_location(39.9390731, 116.117273)
+
+
+@pytest.mark.skip(reason="need a way to use the uploaded files from test_client.py")
+def test_send_files(any_thread):
+    pass

tests/test_session.py

@@ -1,6 +1,6 @@
 import datetime
 import pytest
-from fbchat import ParseError
+from fbchat import ParseError, _util
 from fbchat._session import (
     parse_server_js_define,
     base36encode,
@@ -13,7 +13,7 @@ from fbchat._session import (
 )
 
 
-def test_parse_server_js_define():
+def test_parse_server_js_define_old():
     html = """
     some data;require("TimeSliceImpl").guard(function(){(require("ServerJSDefine")).handleDefines([["DTSGInitialData",[],{"token":"123"},100]])
 
@@ -29,6 +29,20 @@ def test_parse_server_js_define():
     }
 
 
+def test_parse_server_js_define_new():
+    html = """
+    some data;require("TimeSliceImpl").guard(function(){new (require("ServerJS"))().handle({"define":[["DTSGInitialData",[],{"token":""},100]],"require":[...]});}, "ServerJS define", {"root":true})();
+    more data
+    <script><script>require("TimeSliceImpl").guard(function(){var s=new (require("ServerJS"))();s.handle({"define":[["DTSGInitData",[],{"token":"","async_get_token":""},3333]],"require":[...]});require("Run").onAfterLoad(function(){s.cleanup(require("TimeSliceImpl"))});}, "ServerJS define", {"root":true})();</script>
+    other irrelevant data
+    """
+    define = parse_server_js_define(html)
+    assert define == {
+        "DTSGInitialData": {"token": ""},
+        "DTSGInitData": {"async_get_token": "", "token": ""},
+    }
+
+
 def test_parse_server_js_define_error():
     with pytest.raises(ParseError, match="Could not find any"):
         parse_server_js_define("")
@@ -59,7 +73,7 @@ def test_prefix_url():
 
 def test_generate_message_id():
     # Returns random output, so hard to test more thoroughly
-    assert generate_message_id(datetime.datetime.utcnow(), "def")
+    assert generate_message_id(_util.now(), "def")
 
 
 def test_session_factory():

tests/test_util.py

@@ -68,6 +68,17 @@ def test_get_jsmods_require():
     }
 
 
+def test_get_jsmods_require_version_specifier():
+    data = [
+        ["DimensionTracking@1234"],
+        ["CavalryLoggerImpl@2345", "startInstrumentation", [], []],
+    ]
+    assert get_jsmods_require(data) == {
+        "DimensionTracking": [],
+        "CavalryLoggerImpl.startInstrumentation": [],
+    }
+
+
 def test_get_jsmods_require_get_image_url():
     data = [
         [