Housekeeping

- Update README
- Run shellcheck on .sh files
- Add helper scripts
- Remove eirene vm variant
- Add post-install checklist

Signed-off-by: Nikolaos Karaolidis <nick@karaolidis.com>

hosts/common/user/configs/console/gpg-agent/import-gpg-keys.sh

@@ -1,21 +1,21 @@
-for dir in "$HOME"/.config/sops-nix/secrets/gpg-agent/*; do
-  keyfile="$dir/key"
-  passfile="$dir/pass"
+for dir in "${HOME}"/.config/sops-nix/secrets/gpg-agent/*; do
+  keyfile="${dir}/key"
+  passfile="${dir}/pass"
 
-  if [ ! -f "$keyfile" ]; then
+  if [[ ! -f "${keyfile}" ]]; then
     continue
   fi
 
-  if [ -f "$passfile" ]; then
-    gpg2 --batch --yes --pinentry-mode loopback --passphrase-file "$passfile" --import "$keyfile"
+  if [[ -f "${passfile}" ]]; then
+    gpg2 --batch --yes --pinentry-mode loopback --passphrase-file "${passfile}" --import "${keyfile}"
   else
-    gpg2 --batch --yes --import "$keyfile"
+    gpg2 --batch --yes --import "${keyfile}"
   fi
 
-  gpg2 --with-colons --import-options show-only --import "$keyfile" | grep '^fpr' | cut -d: -f10 | while read -r KEY_ID; do
-    echo "$KEY_ID:6:" >> "$GNUPGHOME"/otrust.txt
+  gpg2 --with-colons --import-options show-only --import "${keyfile}" | grep '^fpr' | cut -d: -f10 | while read -r KEY_ID; do
+    echo "${KEY_ID}:6:" >> "${GNUPGHOME}"/otrust.txt
   done
 done
 
-gpg2 --import-ownertrust "$GNUPGHOME"/otrust.txt
-rm "$GNUPGHOME"/otrust.txt
+gpg2 --import-ownertrust "${GNUPGHOME}"/otrust.txt
+rm "${GNUPGHOME}"/otrust.txt

hosts/common/user/configs/gui/cliphist/scripts/copy.sh

@@ -7,7 +7,7 @@ handle() {
   cliphist decode <<< "$1" | wl-copy
 }
 
-case $ROFI_RETV in
+case ${ROFI_RETV} in
   0) list ;;
   1) handle "$@" ;;
 esac

hosts/common/user/configs/gui/cliphist/scripts/delete.sh

@@ -7,7 +7,7 @@ handle() {
   cliphist delete <<< "$1"
 }
 
-case $ROFI_RETV in
+case ${ROFI_RETV} in
   0) list ;;
   1) handle "$@" && list ;;
 esac

hosts/common/user/configs/gui/spicetify/config/merge.sh

@@ -1,19 +1,19 @@
 SOURCE_FILE=$(realpath -m "$1")
 TARGET_FILE=$(realpath -m "$2")
 
-mkdir -p "$(dirname "$TARGET_FILE")"
+mkdir -p "$(dirname "${TARGET_FILE}")"
 
 TEMP_FILE=$(mktemp)
-cat "$SOURCE_FILE" > "$TEMP_FILE"
+cat "${SOURCE_FILE}" > "${TEMP_FILE}"
 
-if [ -f "$TARGET_FILE" ]; then
+if [[ -f "${TARGET_FILE}" ]]; then
   while IFS='=' read -r key value; do
-    if ! grep -q "^${key}=" "$TEMP_FILE"; then
-      echo "${key}=${value}" >> "$TEMP_FILE"
+    if ! grep -q "^${key}=" "${TEMP_FILE}"; then
+      echo "${key}=${value}" >> "${TEMP_FILE}"
     fi
-  done < "$TARGET_FILE"
+  done < "${TARGET_FILE}"
 fi
 
-mv "$TEMP_FILE" "$TARGET_FILE"
+mv "${TEMP_FILE}" "${TARGET_FILE}"
 
-echo "Configuration file $TARGET_FILE has been updated."
+echo "Configuration file ${TARGET_FILE} has been updated."

hosts/common/user/configs/gui/theme/theme.sh

@@ -1,11 +1,11 @@
-[ ! -L "$CONFIG"/wallpaper ] && ln -sf "$DEFAULT_WALLPAPER" "$CONFIG"/wallpaper
-[ ! -f "$CONFIG"/mode ] && echo "$DEFAULT_MODE" > "$CONFIG"/mode
+[[ ! -L "${CONFIG}"/wallpaper ]] && ln -sf "${DEFAULT_WALLPAPER}" "${CONFIG}"/wallpaper
+[[ ! -f "${CONFIG}"/mode ]] && echo "${DEFAULT_MODE}" > "${CONFIG}"/mode
 
 WALLPAPER=""
 MODE=""
 
 set_wallpaper() {
-  if [ -f "$1" ]; then
+  if [[ -f "$1" ]]; then
     WALLPAPER="$1"
   else
     echo "Invalid wallpaper path: $1"
@@ -14,7 +14,7 @@ set_wallpaper() {
 }
 
 set_mode() {
-  if [ "$1" = "light" ] || [ "$1" = "dark" ]; then
+  if [[ "$1" = "light" ]] || [[ "$1" = "dark" ]]; then
     MODE="$1"
   else
     echo "Invalid mode: $1. Use 'light' or 'dark'."
@@ -23,7 +23,7 @@ set_mode() {
 }
 
 toggle_mode() {
-  if [ "$(cat "$CONFIG"/mode)" = "light" ]; then
+  if [[ "$(cat "${CONFIG}"/mode)" = "light" ]]; then
     MODE="dark"
   else
     MODE="light"
@@ -35,18 +35,18 @@ show_usage() {
 }
 
 finish() {
-  [ -n "$WALLPAPER" ] && ln -sf "$WALLPAPER" "$CONFIG"/wallpaper
-  [ -n "$MODE" ] && echo "$MODE" > "$CONFIG"/mode
+  [[ -n "${WALLPAPER}" ]] && ln -sf "${WALLPAPER}" "${CONFIG}"/wallpaper
+  [[ -n "${MODE}" ]] && echo "${MODE}" > "${CONFIG}"/mode
 
-  "$ACTIVATION" > /dev/null
+  "${ACTIVATION}" > /dev/null
 }
 
-if [ $# -eq 0 ]; then
+if [[ $# -eq 0 ]]; then
   finish
 else
   case "$1" in
     toggle)
-      if [ $# -eq 1 ]; then
+      if [[ $# -eq 1 ]]; then
         toggle_mode
       else
         show_usage
@@ -54,7 +54,7 @@ else
       fi
       ;;
     light)
-      if [ $# -eq 1 ]; then
+      if [[ $# -eq 1 ]]; then
         set_mode "light"
       else
         show_usage
@@ -62,7 +62,7 @@ else
       fi
       ;;
     dark)
-      if [ $# -eq 1 ]; then
+      if [[ $# -eq 1 ]]; then
         set_mode "dark"
       else
         show_usage
@@ -70,7 +70,7 @@ else
       fi
       ;;
     mode)
-      if [ $# -eq 2 ]; then
+      if [[ $# -eq 2 ]]; then
         set_mode "$2"
       else
         show_usage
@@ -78,9 +78,9 @@ else
       fi
       ;;
     wallpaper)
-      if [ $# -ge 2 ] && [ $# -le 3 ]; then
+      if [[ $# -ge 2 ]] && [[ $# -le 3 ]]; then
         set_wallpaper "$2"
-        [ $# -eq 3 ] && set_mode "$3"
+        [[ $# -eq 3 ]] && set_mode "$3"
       else
         show_usage
         exit 1