From 2de86b46f7136eb0e22979a2bb39fc62dd14bac0 Mon Sep 17 00:00:00 2001
From: Nikolaos Karaolidis <nick@karaolidis.com>
Date: Sun, 10 Mar 2024 19:51:41 +0000
Subject: [PATCH] Improve backfill error logging

Signed-off-by: Nikolaos Karaolidis <nick@karaolidis.com>
---
 src/threads/data/backfill/bars.rs | 13 ++++++++-----
 src/threads/data/backfill/news.rs | 13 ++++++++-----
 2 files changed, 16 insertions(+), 10 deletions(-)

diff --git a/src/threads/data/backfill/bars.rs b/src/threads/data/backfill/bars.rs
index 1c6f900..0767f20 100644
--- a/src/threads/data/backfill/bars.rs
+++ b/src/threads/data/backfill/bars.rs
@@ -124,7 +124,7 @@ impl super::Handler for Handler {
         let mut next_page_token = None;
 
         loop {
-            let Ok(message) = alpaca::api::incoming::bar::get(
+            let message = alpaca::api::incoming::bar::get(
                 &self.config.alpaca_client,
                 &self.config.alpaca_rate_limiter,
                 self.data_url,
@@ -136,11 +136,14 @@ impl super::Handler for Handler {
                 ),
                 None,
             )
-            .await
-            else {
-                error!("Failed to backfill bars for {:?}.", symbols);
+            .await;
+
+            if let Err(err) = message {
+                error!("Failed to backfill bars for {:?}: {:?}.", symbols, err);
                 return;
-            };
+            }
+
+            let message = message.unwrap();
 
             for (symbol, bar_vec) in message.bars {
                 if let Some(last) = bar_vec.last() {
diff --git a/src/threads/data/backfill/news.rs b/src/threads/data/backfill/news.rs
index 6aa1303..e57e654 100644
--- a/src/threads/data/backfill/news.rs
+++ b/src/threads/data/backfill/news.rs
@@ -86,7 +86,7 @@ impl super::Handler for Handler {
         let mut next_page_token = None;
 
         loop {
-            let Ok(message) = alpaca::api::incoming::news::get(
+            let message = alpaca::api::incoming::news::get(
                 &self.config.alpaca_client,
                 &self.config.alpaca_rate_limiter,
                 &alpaca::api::outgoing::news::News {
@@ -99,11 +99,14 @@ impl super::Handler for Handler {
                 },
                 None,
             )
-            .await
-            else {
-                error!("Failed to backfill news for {:?}.", symbols);
+            .await;
+
+            if let Err(err) = message {
+                error!("Failed to backfill news for {:?}: {:?}.", symbols, err);
                 return;
-            };
+            }
+
+            let message = message.unwrap();
 
             for news_item in message.news {
                 let news_item = News::from(news_item);