From b7a175d5b4862203d310fbc91d28f6f199e7666a Mon Sep 17 00:00:00 2001
From: Nikolaos Karaolidis <nick@karaolidis.com>
Date: Sun, 17 Mar 2024 09:22:45 +0000
Subject: [PATCH] Improve ser function naming

Signed-off-by: Nikolaos Karaolidis <nick@karaolidis.com>
---
 src/lib/types/alpaca/api/outgoing/news.rs |  2 +-
 src/lib/utils/ser.rs                      | 12 +++++-------
 2 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/src/lib/types/alpaca/api/outgoing/news.rs b/src/lib/types/alpaca/api/outgoing/news.rs
index b4b9227..4236fbc 100644
--- a/src/lib/types/alpaca/api/outgoing/news.rs
+++ b/src/lib/types/alpaca/api/outgoing/news.rs
@@ -4,7 +4,7 @@ use time::OffsetDateTime;
 
 #[derive(Serialize)]
 pub struct News {
-    #[serde(serialize_with = "ser::remove_slash_from_pairs_join_symbols")]
+    #[serde(serialize_with = "ser::remove_slash_and_join_symbols")]
     pub symbols: Vec<String>,
     #[serde(skip_serializing_if = "Option::is_none")]
     #[serde(with = "time::serde::rfc3339::option")]
diff --git a/src/lib/utils/ser.rs b/src/lib/utils/ser.rs
index 09a3499..e19840f 100644
--- a/src/lib/utils/ser.rs
+++ b/src/lib/utils/ser.rs
@@ -58,12 +58,12 @@ where
     }
 }
 
-pub fn remove_slash_from_symbols<'a, S, I>(pairs: I, serializer: S) -> Result<S::Ok, S::Error>
+pub fn remove_slash_from_symbols<'a, S, I>(symbols: I, serializer: S) -> Result<S::Ok, S::Error>
 where
     S: Serializer,
     I: IntoIterator<Item = &'a String>,
 {
-    let symbols = pairs
+    let symbols = symbols
         .into_iter()
         .map(|pair| remove_slash(pair))
         .collect::<Vec<_>>();
@@ -75,15 +75,13 @@ where
     seq.end()
 }
 
-pub fn remove_slash_from_pairs_join_symbols<S>(
-    symbols: &[String],
-    serializer: S,
-) -> Result<S::Ok, S::Error>
+pub fn remove_slash_and_join_symbols<'a, S, I>(symbols: I, serializer: S) -> Result<S::Ok, S::Error>
 where
     S: Serializer,
+    I: IntoIterator<Item = &'a String>,
 {
     let symbols = symbols
-        .iter()
+        .into_iter()
         .map(|symbol| remove_slash(symbol))
         .collect::<Vec<_>>();