Rename clickhouse variable

Signed-off-by: Nikolaos Karaolidis <nick@karaolidis.com>
This commit is contained in:
2023-06-29 16:21:33 +03:00
parent e0b329fd65
commit da3d08912d

View File

@@ -55,53 +55,53 @@ func (*ClickHouse) SampleConfig() string {
return sampleConfig return sampleConfig
} }
func (p *ClickHouse) Init() error { func (ch *ClickHouse) Init() error {
if p.DataSourceName == "" { if ch.DataSourceName == "" {
return fmt.Errorf("data_source_name is a required configuration option") return fmt.Errorf("data_source_name is a required configuration option")
} }
if p.TimestampColumn == "" { if ch.TimestampColumn == "" {
p.TimestampColumn = "timestamp" ch.TimestampColumn = "timestamp"
p.Log.Info("timestamp_column is not set, using default value:", p.TimestampColumn) ch.Log.Info("timestamp_column is not set, using default value:", ch.TimestampColumn)
} }
if p.TableMode == "" { if ch.TableMode == "" {
p.TableMode = "multi" ch.TableMode = "multi"
p.Log.Info("table_mode is not set, using default value:", p.TableMode) ch.Log.Info("table_mode is not set, using default value:", ch.TableMode)
} else if p.TableMode != "single" && p.TableMode != "multi" { } else if ch.TableMode != "single" && ch.TableMode != "multi" {
return fmt.Errorf("table_mode must be one of: single, multi") return fmt.Errorf("table_mode must be one of: single, multi")
} }
if p.TableMode == "single" && p.SingleTableOptions.TableName == "" { if ch.TableMode == "single" && ch.SingleTableOptions.TableName == "" {
p.SingleTableOptions.TableName = "telegraf" ch.SingleTableOptions.TableName = "telegraf"
p.Log.Info("table_name is not set, using default value:", p.SingleTableOptions.TableName) ch.Log.Info("table_name is not set, using default value:", ch.SingleTableOptions.TableName)
} }
if p.QueueSize <= 0 { if ch.QueueSize <= 0 {
p.QueueSize = 100000 ch.QueueSize = 100000
p.Log.Info("queue_size is not set, using default value:", p.QueueSize) ch.Log.Info("queue_size is not set, using default value:", ch.QueueSize)
} }
if p.QueueLimit <= 0 { if ch.QueueLimit <= 0 {
p.QueueLimit = int(math.MaxUint64 >> 1) ch.QueueLimit = int(math.MaxUint64 >> 1)
p.Log.Info("queue_limit is not set, using default value:", p.QueueLimit) ch.Log.Info("queue_limit is not set, using default value:", ch.QueueLimit)
} }
if p.FlushInterval <= 0 { if ch.FlushInterval <= 0 {
p.FlushInterval = 5 * time.Second ch.FlushInterval = 5 * time.Second
p.Log.Info("flush_interval is not set, using default value:", p.FlushInterval) ch.Log.Info("flush_interval is not set, using default value:", ch.FlushInterval)
} }
p.metricQueue = make([]telegraf.Metric, 0, p.QueueSize) ch.metricQueue = make([]telegraf.Metric, 0, ch.QueueSize)
p.metricTrigger = make(chan struct{}, 1) ch.metricTrigger = make(chan struct{}, 1)
go p.metricWriter(p.FlushInterval) go ch.metricWriter(ch.FlushInterval)
return nil return nil
} }
func (p *ClickHouse) Connect() error { func (ch *ClickHouse) Connect() error {
db, err := sql.Open("clickhouse", p.DataSourceName) db, err := sql.Open("clickhouse", ch.DataSourceName)
if err != nil { if err != nil {
return err return err
} }
@@ -111,26 +111,26 @@ func (p *ClickHouse) Connect() error {
return err return err
} }
db.SetConnMaxIdleTime(time.Duration(p.ConnectionMaxIdleTime)) db.SetConnMaxIdleTime(time.Duration(ch.ConnectionMaxIdleTime))
db.SetConnMaxLifetime(time.Duration(p.ConnectionMaxLifetime)) db.SetConnMaxLifetime(time.Duration(ch.ConnectionMaxLifetime))
db.SetMaxIdleConns(p.ConnectionMaxIdle) db.SetMaxIdleConns(ch.ConnectionMaxIdle)
db.SetMaxOpenConns(p.ConnectionMaxOpen) db.SetMaxOpenConns(ch.ConnectionMaxOpen)
if p.InitSQL != "" { if ch.InitSQL != "" {
_, err = db.Exec(p.InitSQL) _, err = db.Exec(ch.InitSQL)
if err != nil { if err != nil {
return err return err
} }
} }
p.db = db ch.db = db
p.Log.Info("Connected to ClickHouse!") ch.Log.Info("Connected to ClickHouse!")
return nil return nil
} }
func (p *ClickHouse) Close() error { func (ch *ClickHouse) Close() error {
return p.db.Close() return ch.db.Close()
} }
func sanitizeQuoted(in string) string { func sanitizeQuoted(in string) string {
@@ -150,7 +150,7 @@ func quoteIdent(name string) string {
return `"` + strings.ReplaceAll(sanitizeQuoted(name), `"`, `""`) + `"` return `"` + strings.ReplaceAll(sanitizeQuoted(name), `"`, `""`) + `"`
} }
func (p *ClickHouse) valueToDatatype(value interface{}) string { func (ch *ClickHouse) valueToDatatype(value interface{}) string {
var datatype string var datatype string
switch value.(type) { switch value.(type) {
@@ -168,43 +168,42 @@ func (p *ClickHouse) valueToDatatype(value interface{}) string {
datatype = "DateTime" datatype = "DateTime"
default: default:
datatype = "String" datatype = "String"
p.Log.Errorf("unknown datatype for value %v", value) ch.Log.Errorf("unknown datatype for value %v", value)
} }
return datatype return datatype
} }
// TODO: fix this fuckyness
type NullUint64 struct { type NullUint64 struct {
Uint64 uint64 Uint64 uint64
Valid bool Valid bool
} }
func (p *ClickHouse) datatypeToNullable(datatype string) interface{} { func (ch *ClickHouse) datatypeToNullable(datatype string) interface{} {
var nullable interface{} var nullable interface{}
switch datatype { switch datatype {
case "Int64": case "Int64":
nullable = int64(0) // sql.NullInt64{} nullable = sql.NullInt64{Int64: 0, Valid: false}
case "UInt64": case "UInt64":
nullable = uint64(0) // NullUint64{} nullable = NullUint64{Uint64: 0, Valid: false}
case "Float64": case "Float64":
nullable = float64(0) // sql.NullFloat64{} nullable = sql.NullFloat64{Float64: 0, Valid: false}
case "String": case "String":
nullable = "" // sql.NullString{} nullable = sql.NullString{String: "", Valid: false}
case "UInt8": case "UInt8":
nullable = false // sql.NullBool{} nullable = sql.NullBool{Bool: false, Valid: false}
case "DateTime": case "DateTime":
nullable = time.Unix(0, 0) // sql.NullTime{} nullable = sql.NullTime{Time: time.Unix(0, 0), Valid: false}
default: default:
nullable = "" // sql.NullString{} nullable = sql.NullString{String: "", Valid: false}
p.Log.Errorf("unknown datatype %s", datatype) ch.Log.Errorf("unknown datatype %s", datatype)
} }
return nullable return nullable
} }
func (p *ClickHouse) generateCreateTable(tablename string, columns *orderedmap.OrderedMap[string, string]) string { func (ch *ClickHouse) generateCreateTable(tablename string, columns *orderedmap.OrderedMap[string, string]) string {
columnDefs := make([]string, 0, columns.Len()) columnDefs := make([]string, 0, columns.Len())
for pair := columns.Oldest(); pair != nil; pair = pair.Next() { for pair := columns.Oldest(); pair != nil; pair = pair.Next() {
@@ -215,7 +214,7 @@ func (p *ClickHouse) generateCreateTable(tablename string, columns *orderedmap.O
if _, ok := columns.Get("host"); ok { if _, ok := columns.Get("host"); ok {
orderBy = append(orderBy, "host") orderBy = append(orderBy, "host")
} }
orderBy = append(orderBy, quoteIdent(p.TimestampColumn)) orderBy = append(orderBy, quoteIdent(ch.TimestampColumn))
if _, ok := columns.Get("measurement"); ok { if _, ok := columns.Get("measurement"); ok {
orderBy = append(orderBy, "measurement") orderBy = append(orderBy, "measurement")
} }
@@ -224,16 +223,16 @@ func (p *ClickHouse) generateCreateTable(tablename string, columns *orderedmap.O
quoteIdent(tablename), quoteIdent(tablename),
strings.Join(columnDefs, ","), strings.Join(columnDefs, ","),
strings.Join(orderBy, ","), strings.Join(orderBy, ","),
quoteIdent(p.TimestampColumn)) quoteIdent(ch.TimestampColumn))
if p.TTL != "" { if ch.TTL != "" {
createTable += fmt.Sprintf(" TTL %s + INTERVAL %s", quoteIdent(p.TimestampColumn), p.TTL) createTable += fmt.Sprintf(" TTL %s + INTERVAL %s", quoteIdent(ch.TimestampColumn), ch.TTL)
} }
return createTable return createTable
} }
func (p *ClickHouse) generateAlterTable(tablename string, columns *orderedmap.OrderedMap[string, string]) string { func (ch *ClickHouse) generateAlterTable(tablename string, columns *orderedmap.OrderedMap[string, string]) string {
alterDefs := make([]string, 0, columns.Len()) alterDefs := make([]string, 0, columns.Len())
for pair := columns.Oldest(); pair != nil; pair = pair.Next() { for pair := columns.Oldest(); pair != nil; pair = pair.Next() {
@@ -247,21 +246,21 @@ func (p *ClickHouse) generateAlterTable(tablename string, columns *orderedmap.Or
strings.Join(alterDefs, ",")) strings.Join(alterDefs, ","))
} }
func (p *ClickHouse) ensureTable(tablename string, columns *orderedmap.OrderedMap[string, string]) error { func (ch *ClickHouse) ensureTable(tablename string, columns *orderedmap.OrderedMap[string, string]) error {
var res *sql.Rows var res *sql.Rows
var err error var err error
for { for {
res, err = p.db.Query(fmt.Sprintf("DESCRIBE TABLE %s", quoteIdent(tablename))) res, err = ch.db.Query(fmt.Sprintf("DESCRIBE TABLE %s", quoteIdent(tablename)))
if err != nil { if err != nil {
// Unknown Table Error // Unknown Table Error
if strings.Contains(err.Error(), "code: 60") { if strings.Contains(err.Error(), "code: 60") {
_, err = p.db.Exec(p.generateCreateTable(tablename, columns)) _, err = ch.db.Exec(ch.generateCreateTable(tablename, columns))
if err != nil { if err != nil {
return err return err
} }
p.Log.Info("Created table", tablename) ch.Log.Info("Created table", tablename)
continue continue
} }
return err return err
@@ -286,11 +285,11 @@ func (p *ClickHouse) ensureTable(tablename string, columns *orderedmap.OrderedMa
for pair := columns.Oldest(); pair != nil; pair = pair.Next() { for pair := columns.Oldest(); pair != nil; pair = pair.Next() {
if _, ok := tableColumns[pair.Key]; !ok { if _, ok := tableColumns[pair.Key]; !ok {
_, err = p.db.Exec(p.generateAlterTable(tablename, columns)) _, err = ch.db.Exec(ch.generateAlterTable(tablename, columns))
if err != nil { if err != nil {
return err return err
} }
p.Log.Info("Altered table", tablename) ch.Log.Info("Altered table", tablename)
break break
} }
} }
@@ -298,7 +297,7 @@ func (p *ClickHouse) ensureTable(tablename string, columns *orderedmap.OrderedMa
return nil return nil
} }
func (p *ClickHouse) generateInsert(tablename string, columns *orderedmap.OrderedMap[string, string], batchSize int) string { func (ch *ClickHouse) generateInsert(tablename string, columns *orderedmap.OrderedMap[string, string], batchSize int) string {
quotedColumns := make([]string, 0, columns.Len()) quotedColumns := make([]string, 0, columns.Len())
for pair := columns.Oldest(); pair != nil; pair = pair.Next() { for pair := columns.Oldest(); pair != nil; pair = pair.Next() {
quotedColumns = append(quotedColumns, quoteIdent(pair.Key)) quotedColumns = append(quotedColumns, quoteIdent(pair.Key))
@@ -313,25 +312,25 @@ func (p *ClickHouse) generateInsert(tablename string, columns *orderedmap.Ordere
placeholders) placeholders)
} }
func (p *ClickHouse) nullifyMissingValues(columns *orderedmap.OrderedMap[string, string], metrics []map[string]interface{}) { func (ch *ClickHouse) nullifyMissingValues(columns *orderedmap.OrderedMap[string, string], metrics []map[string]interface{}) {
for _, metric := range metrics { for _, metric := range metrics {
for pair := columns.Oldest(); pair != nil; pair = pair.Next() { for pair := columns.Oldest(); pair != nil; pair = pair.Next() {
if _, ok := metric[pair.Key]; !ok { if _, ok := metric[pair.Key]; !ok {
metric[pair.Key] = p.datatypeToNullable(pair.Value) metric[pair.Key] = ch.datatypeToNullable(pair.Value)
} }
} }
} }
} }
func (p *ClickHouse) writeMetrics(tablename string, columns *orderedmap.OrderedMap[string, string], metrics []map[string]interface{}) error { func (ch *ClickHouse) writeMetrics(tablename string, columns *orderedmap.OrderedMap[string, string], metrics []map[string]interface{}) error {
err := p.ensureTable(tablename, columns) err := ch.ensureTable(tablename, columns)
if err != nil { if err != nil {
return err return err
} }
sql := p.generateInsert(tablename, columns, len(metrics)) sql := ch.generateInsert(tablename, columns, len(metrics))
tx, err := p.db.Begin() tx, err := ch.db.Begin()
if err != nil { if err != nil {
return fmt.Errorf("begin failed: %w", err) return fmt.Errorf("begin failed: %w", err)
} }
@@ -369,7 +368,7 @@ func (p *ClickHouse) writeMetrics(tablename string, columns *orderedmap.OrderedM
return nil return nil
} }
func (p *ClickHouse) WriteMultiTable(metrics []telegraf.Metric) error { func (ch *ClickHouse) WriteMultiTable(metrics []telegraf.Metric) error {
metricsData := make(map[string][]map[string]interface{}) metricsData := make(map[string][]map[string]interface{})
columns := make(map[string]*orderedmap.OrderedMap[string, string]) columns := make(map[string]*orderedmap.OrderedMap[string, string])
@@ -377,8 +376,8 @@ func (p *ClickHouse) WriteMultiTable(metrics []telegraf.Metric) error {
for _, metric := range metrics { for _, metric := range metrics {
tablename := metric.Name() tablename := metric.Name()
if p.MultiTableOptions.TablePrefix != "" { if ch.MultiTableOptions.TablePrefix != "" {
tablename = p.MultiTableOptions.TablePrefix + "_" + tablename tablename = ch.MultiTableOptions.TablePrefix + "_" + tablename
} }
if _, ok := metricsData[tablename]; !ok { if _, ok := metricsData[tablename]; !ok {
@@ -391,41 +390,41 @@ func (p *ClickHouse) WriteMultiTable(metrics []telegraf.Metric) error {
metricEntry := make(map[string]interface{}) metricEntry := make(map[string]interface{})
metricEntry[p.TimestampColumn] = metric.Time() metricEntry[ch.TimestampColumn] = metric.Time()
columns[tablename].Set(p.TimestampColumn, p.valueToDatatype(metric.Time())) columns[tablename].Set(ch.TimestampColumn, ch.valueToDatatype(metric.Time()))
for _, tag := range metric.TagList() { for _, tag := range metric.TagList() {
metricEntry[tag.Key] = tag.Value metricEntry[tag.Key] = tag.Value
columns[tablename].Set(tag.Key, p.valueToDatatype(tag.Value)) columns[tablename].Set(tag.Key, ch.valueToDatatype(tag.Value))
} }
for _, field := range metric.FieldList() { for _, field := range metric.FieldList() {
metricEntry[field.Key] = field.Value metricEntry[field.Key] = field.Value
columns[tablename].Set(field.Key, p.valueToDatatype(field.Value)) columns[tablename].Set(field.Key, ch.valueToDatatype(field.Value))
} }
metricsData[tablename] = append(metricsData[tablename], metricEntry) metricsData[tablename] = append(metricsData[tablename], metricEntry)
} }
for tablename, metrics := range metricsData { for tablename, metrics := range metricsData {
p.nullifyMissingValues(columns[tablename], metrics) ch.nullifyMissingValues(columns[tablename], metrics)
} }
p.Log.Infof("Prepared %d metrics for writing in %s\n", len(metrics), time.Since(start)) ch.Log.Infof("Prepared %d metrics for writing in %s\n", len(metrics), time.Since(start))
start = time.Now() start = time.Now()
for tablename, metrics := range metricsData { for tablename, metrics := range metricsData {
err := p.writeMetrics(tablename, columns[tablename], metrics) err := ch.writeMetrics(tablename, columns[tablename], metrics)
if err != nil { if err != nil {
return err return err
} }
} }
p.Log.Infof("Wrote %d metrics to %d tables in %s\n", len(metrics), len(metricsData), time.Since(start)) ch.Log.Infof("Wrote %d metrics to %d tables in %s\n", len(metrics), len(metricsData), time.Since(start))
return nil return nil
} }
func (p *ClickHouse) WriteSingleTable(metrics []telegraf.Metric) error { func (ch *ClickHouse) WriteSingleTable(metrics []telegraf.Metric) error {
tablename := p.SingleTableOptions.TableName tablename := ch.SingleTableOptions.TableName
metricsData := make([]map[string]interface{}, 0, len(metrics)) metricsData := make([]map[string]interface{}, 0, len(metrics))
columns := orderedmap.New[string, string](len(metrics)) columns := orderedmap.New[string, string](len(metrics))
@@ -434,92 +433,92 @@ func (p *ClickHouse) WriteSingleTable(metrics []telegraf.Metric) error {
metricName := metric.Name() metricName := metric.Name()
metricEntry := make(map[string]interface{}) metricEntry := make(map[string]interface{})
metricEntry[p.TimestampColumn] = metric.Time() metricEntry[ch.TimestampColumn] = metric.Time()
columns.Set(p.TimestampColumn, p.valueToDatatype(metric.Time())) columns.Set(ch.TimestampColumn, ch.valueToDatatype(metric.Time()))
metricEntry["measurement"] = metricName metricEntry["measurement"] = metricName
columns.Set("measurement", p.valueToDatatype(metricName)) columns.Set("measurement", ch.valueToDatatype(metricName))
for _, tag := range metric.TagList() { for _, tag := range metric.TagList() {
colName := fmt.Sprintf("%s_%s", metricName, tag.Key) colName := fmt.Sprintf("%s_%s", metricName, tag.Key)
metricEntry[colName] = tag.Value metricEntry[colName] = tag.Value
columns.Set(colName, p.valueToDatatype(tag.Value)) columns.Set(colName, ch.valueToDatatype(tag.Value))
} }
for _, field := range metric.FieldList() { for _, field := range metric.FieldList() {
colName := fmt.Sprintf("%s_%s", metricName, field.Key) colName := fmt.Sprintf("%s_%s", metricName, field.Key)
metricEntry[colName] = field.Value metricEntry[colName] = field.Value
columns.Set(colName, p.valueToDatatype(field.Value)) columns.Set(colName, ch.valueToDatatype(field.Value))
} }
for pair := columns.Oldest(); pair != nil; pair = pair.Next() { for pair := columns.Oldest(); pair != nil; pair = pair.Next() {
if _, ok := metricEntry[pair.Key]; !ok { if _, ok := metricEntry[pair.Key]; !ok {
metricEntry[pair.Key] = p.datatypeToNullable(pair.Value) metricEntry[pair.Key] = ch.datatypeToNullable(pair.Value)
} }
} }
metricsData = append(metricsData, metricEntry) metricsData = append(metricsData, metricEntry)
} }
p.nullifyMissingValues(columns, metricsData) ch.nullifyMissingValues(columns, metricsData)
p.Log.Infof("Prepared %d metrics for writing in %s\n", len(metrics), time.Since(start)) ch.Log.Infof("Prepared %d metrics for writing in %s\n", len(metrics), time.Since(start))
start = time.Now() start = time.Now()
err := p.writeMetrics(tablename, columns, metricsData) err := ch.writeMetrics(tablename, columns, metricsData)
if err != nil { if err != nil {
return err return err
} }
p.Log.Infof("Wrote %d metrics to %s in %s\n", len(metrics), tablename, time.Since(start)) ch.Log.Infof("Wrote %d metrics to %s in %s\n", len(metrics), tablename, time.Since(start))
return nil return nil
} }
func (p *ClickHouse) Write(metrics []telegraf.Metric) error { func (ch *ClickHouse) Write(metrics []telegraf.Metric) error {
p.metricLock.Lock() ch.metricLock.Lock()
if len(p.metricQueue) >= p.QueueLimit { if len(ch.metricQueue) >= ch.QueueLimit {
p.Log.Errorf("Metrics queue is full (%d/%d), dropping metrics", len(p.metricQueue), p.QueueLimit) ch.Log.Errorf("Metrics queue is full (%d/%d), dropping metrics", len(ch.metricQueue), ch.QueueLimit)
} else { } else {
p.metricQueue = append(p.metricQueue, metrics...) ch.metricQueue = append(ch.metricQueue, metrics...)
} }
p.metricLock.Unlock() ch.metricLock.Unlock()
select { select {
case p.metricTrigger <- struct{}{}: case ch.metricTrigger <- struct{}{}:
default: default:
} }
return nil return nil
} }
func (p *ClickHouse) metricWriter(delay time.Duration) { func (ch *ClickHouse) metricWriter(delay time.Duration) {
timer := time.NewTimer(delay) timer := time.NewTimer(delay)
defer timer.Stop() defer timer.Stop()
for { for {
select { select {
case <-timer.C: case <-timer.C:
p.metricLock.Lock() ch.metricLock.Lock()
metrics := p.metricQueue metrics := ch.metricQueue
p.metricQueue = nil ch.metricQueue = nil
p.metricLock.Unlock() ch.metricLock.Unlock()
if len(metrics) > 0 { if len(metrics) > 0 {
if p.TableMode == "single" { if ch.TableMode == "single" {
err := p.WriteSingleTable(metrics) err := ch.WriteSingleTable(metrics)
if err != nil { if err != nil {
p.Log.Errorf("Error writing to ClickHouse: %s", err) ch.Log.Errorf("Error writing to ClickHouse: %s", err)
} }
} else { } else {
err := p.WriteMultiTable(metrics) err := ch.WriteMultiTable(metrics)
if err != nil { if err != nil {
p.Log.Errorf("Error writing to ClickHouse: %s", err) ch.Log.Errorf("Error writing to ClickHouse: %s", err)
} }
} }
} }
timer.Reset(delay) timer.Reset(delay)
case <-p.metricTrigger: case <-ch.metricTrigger:
if !timer.Stop() { if !timer.Stop() {
<-timer.C <-timer.C
} }